Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1330 +/- ##
=======================================
Coverage 94.99% 94.99%
=======================================
Files 42 42
Lines 2755 2759 +4
=======================================
+ Hits 2617 2621 +4
Misses 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Would it be more appropriate to have the docs url be at My concerns are that:
|
|
I think having
|
|
Okay let's go for it. Should we also have a redirect from the now empty |
I think that is overkill We should also get some opinions from @DiamondLightSource/developers-daq-core |
|
Having Personally I think making Alternatively it could be a landing page with readme level docs/status on - stuff like current version and where to find other services (tiled/glazed/numtracker) as well as a link to the current jsonapi docs and the general docs. Not completely against moving the api docs to |
|
You can have a look at this PR to check how you can do redirect |
This reverts commit c467cd8.
Add status code assertion to redirection test Co-authored-by: Zoheb Shaikh <zoheb.shaikh@diamond.ac.uk>
When interacting with BlueAPI via web browser, the landing page (
/) returns a 404.This has led to other developers having to ask how to access the web-based interface (at
/docs).This PR will have the root page return something meaningful.